JS: Mark AngularJS $location as client-side remote flow source #19587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AngularJS $location handler to be recognized as a client-side remote flow source and differentiates query vs. fragment usage.
- Switch base class from
RemoteFlowSourcetoClientSideRemoteFlowSource - Introduce a
kindfield to distinguish query (search) vs. fragment (hash) - Override
getKind()to expose the newkind
| private class LocationFlowSource extends RemoteFlowSource instanceof DataFlow::MethodCallNode { | ||
| private class LocationFlowSource extends ClientSideRemoteFlowSource instanceof DataFlow::MethodCallNode | ||
| { | ||
| private ClientSideRemoteFlowKind kind; |
There was a problem hiding this comment.
The kind field is never assigned, so calls to kind.isQuery() or kind.isFragment() will fail. Assign kind = ClientSideRemoteFlowKind.Query when m == "search" and kind = ClientSideRemoteFlowKind.Fragment when m == "hash`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.